-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hier connect with test #6413
Hier connect with test #6413
Conversation
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
…mode Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
clang-tidy review says "All clean, LGTM! 👍" |
…m on modnet Signed-off-by: andyfox-rushc <andy@rushc.com>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: andyfox-rushc <andy@rushc.com>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: andyfox-rushc <andy@rushc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: andyfox-rushc <andy@rushc.com>
clang-tidy review says "All clean, LGTM! 👍" |
Hi, @andyfox-rushc. Thanks for your contribution to the work on hierarchy support in ODB. It seems like some performance issue with hierarchical ODB when I try before, i.e., very slow on large hierarchical designs. So, I wanna know if there is any more update for ODB hierarchical or if it's already a stable version to use. Very thanks for your reply! |
Hi, Joy, thank you for the interest in the hierarchy project. Yes, you are quite right, it is very much a work in progress. If possible please could you send me (andy@rushc.com) or attach to this thread, a sample large case for me to try and I will endeavour to clean up the performance. I am currently working through cts and then once we have gcd going through the whole flow will iterate to improve. Thanks again, andy. |
Hi, Joy, thank you for the interest in the hierarchy project. Yes, you are quite right, it is very much a work in progress. If possible please could you send me ***@***.*** ***@***.***) or attach to this thread, a sample large case for me to try and I will endeavour to clean up the performance. I am currently working through cts and then once we have gcd going through the whole flow will iterate to improve. Thanks again, andy.
… On 01/14/2025 6:08 PM PST Joy ***@***.***> wrote:
Hi, @andyfox-rushc https://github.com/andyfox-rushc. Thanks for your contribution to the work on hierarchy support in ODB. It seems like some performance issue with hierarchical ODB when I try before, i.e., very slow on large hierarchical designs. So, I wanna know if there is any more update for ODB hierarchical or if it's already a stable version to use. Very thanks for your reply!
—
Reply to this email directly, view it on GitHub #6413 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRTF7QXWLFYXRXTTZCBMHL2KW7JFAVCNFSM6AAAAABUB4D6RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGQ4DINJYG4.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This pull request includes a C++ test case which builds a multiple level hierarchical design and exercises the creation of a hierarchical connection. This involved adding a cpp directory to the dbSta/test area. The main contribution of this pull request is a c++ level creation of a hierarchical test case.
Also included is a bug fix to the construction of the hierarchy extraction (getParentHierarchy) code which was causing a seg fault.
Ready for review.